-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet deploy and test #19
Conversation
8bd2572
to
7f40c3a
Compare
6c39064
to
2fbd160
Compare
I do not get why build on 22 fails. |
@dmtrskv Hey, just check the issue and it is related to node version. To be more specific our GH action is using I tried locally to use this version and have the same issue. I checked the latest release and found these is a patch fix If you checkout this release you can see that it fixes the error we have: This fix was release 3h ago, so i assume it will just take some time to propage version, @ukorvl an i right? |
3658772
to
db26bda
Compare
Merged the commits and moved tests to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Than you for opening PR and adding this!
Generating and deploying new wallet if one does not exist. First of all, required for tests (we have no other reasonable way to create a wallet in hardhat tests actually, because we must inject it into the handler context). But also can be useful for cli use, so that a user won't have to use nil_cli.
The private key is required by hardhat, so we shouldn't generate it.
Here I generate the wallet address if it is not provided.
If the wallet is not deployed to the address (either provided or generated), then it is deployed.
For this I fixed extendEnvironment which actually contained a race between the test and the setup (due to async func being called before setting up send and request functions; we should wait inside them on the promise).
The second commit introduces incrementer ignition module from example and a script running it. I think we'll need a trivial test of the hardhat cli of such kind.