Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move integration tests #101

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Move integration tests #101

merged 1 commit into from
Jul 29, 2024

Conversation

ukorvl
Copy link
Member

@ukorvl ukorvl commented Jul 18, 2024

Move integration tests to tests directory.

@ukorvl ukorvl requested a review from KlonD90 July 18, 2024 19:42
@ukorvl ukorvl self-assigned this Jul 18, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 32190e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ukorvl ukorvl force-pushed the 87-integration-testing-setup branch 2 times, most recently from 62a0480 to c026f06 Compare July 22, 2024 10:16
dmtrskv
dmtrskv previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@dmtrskv dmtrskv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (apart from failing tests)

src/utils/receipt.ts Outdated Show resolved Hide resolved
@ukorvl ukorvl marked this pull request as draft July 29, 2024 06:29
@ukorvl ukorvl force-pushed the 87-integration-testing-setup branch from c026f06 to f751fce Compare July 29, 2024 10:19
@ukorvl ukorvl force-pushed the 87-integration-testing-setup branch from f751fce to 32190e4 Compare July 29, 2024 10:26
@ukorvl ukorvl marked this pull request as ready for review July 29, 2024 10:27
KlonD90
KlonD90 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@KlonD90 KlonD90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's ok. do not forget to change how it work with nil repository

@ukorvl ukorvl merged commit 1f78390 into master Jul 29, 2024
2 checks passed
@ukorvl ukorvl mentioned this pull request Aug 6, 2024
Closed
@olegrok olegrok deleted the 87-integration-testing-setup branch December 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlonD90 KlonD90 KlonD90 approved these changes

@dmtrskv dmtrskv dmtrskv left review comments

Assignees

@ukorvl ukorvl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ukorvl @KlonD90 @dmtrskv