Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof-producer: rw & zkevm sat check fixes #183

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

oclaw
Copy link
Contributor

@oclaw oclaw commented Dec 6, 2024

Following changes:

  • Added sort of rw_operations_vector before passing it into assignment + refactored copypaste in copy and zkevm circuits
  • Removed some old comments
  • Fixed build
  • Add dummy impl for not implemented opcodes in order to enable checks for zkevm circuit
  • Added traces with single call of increment and parametrized tests with them
  • Enabled single tx check for rw and bytecode circuits

Now disabled checks are

  • zkevm both single and multiple trace (cause is to be investigated)
  • bytecode multiple trace (cause is to be investigated)
  • rw multiple trace (most probably bug in circuit)

@oclaw oclaw requested a review from akokoshn December 6, 2024 16:44
@oclaw oclaw enabled auto-merge December 6, 2024 16:50
Copy link

github-actions bot commented Dec 6, 2024

Gcc Test Results

  159 files  ±0    159 suites  ±0   19m 6s ⏱️ +6s
3 176 tests +4  3 170 ✅ +4  6 💤 ±0  0 ❌ ±0 
3 264 runs  +4  3 258 ✅ +4  6 💤 ±0  0 ❌ ±0 

Results for commit d1fe4c7. ± Comparison against base commit eec3173.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 6, 2024

Clang Test Results

  159 files  ± 0    159 suites  ±0   18m 11s ⏱️ -2s
3 079 tests  - 97  3 073 ✅  - 97  6 💤 ±0  0 ❌ ±0 
3 167 runs   - 97  3 161 ✅  - 97  6 💤 ±0  0 ❌ ±0 

Results for commit d1fe4c7. ± Comparison against base commit eec3173.

This pull request removes 103 and adds 6 tests. Note that renamed tests count towards both.
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
pack_equal_test_suite ‑ bubb_to_bubb_1
pack_equal_test_suite ‑ bubb_to_bubb_2
pack_equal_test_suite ‑ bubb_to_bubb_3
pack_equal_test_suite ‑ bubb_to_bulb_1
pack_equal_test_suite ‑ bubb_to_bulb_2
pack_equal_test_suite ‑ bubb_to_lubb_1
…
pack_imploder_test_suite ‑ be_to_be_1
pack_imploder_test_suite ‑ be_to_be_2
pack_imploder_test_suite ‑ be_to_le_1
pack_imploder_test_suite ‑ be_to_le_2
pack_imploder_test_suite ‑ be_to_le_3
pack_imploder_test_suite ‑ bubb_to_lulb_4

♻️ This comment has been updated with latest results.

@oclaw oclaw added the blueprint label Dec 6, 2024
@oclaw oclaw self-assigned this Dec 6, 2024
@oclaw oclaw force-pushed the fix/rw-circuit-sorted-ops branch from f0ef867 to 86b8b79 Compare December 10, 2024 16:53
@oclaw oclaw requested review from akokoshn and makxenov December 10, 2024 16:57
@oclaw oclaw force-pushed the fix/rw-circuit-sorted-ops branch from bbd57cf to 4752806 Compare December 10, 2024 19:09
Copy link

@oclaw oclaw added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit d0a06c5 Dec 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants