Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiprecision refactoring and tests #204

Merged
merged 18 commits into from
Dec 16, 2024
Merged

Multiprecision refactoring and tests #204

merged 18 commits into from
Dec 16, 2024

Conversation

ioxid
Copy link
Contributor

@ioxid ioxid commented Dec 13, 2024 •
edited
Loading

Moved all operators into class definitions, moved things around.
Also implemented json-based tests which replace the ones based on boost::multiprecision::cpp_int conversions.

@ioxid ioxid force-pushed the multiprecision-refactoring-step-2 branch from f5b317c to 4ec6f44 Compare December 13, 2024 13:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Clang Test Results

  158 files   -     1    158 suites   - 1   16m 17s ⏱️ -6s
7 075 tests +3 994  7 069 ✅ +3 994  6 💤 ±0  0 ❌ ±0 
7 159 runs  +3 990  7 153 ✅ +3 990  6 💤 ±0  0 ❌ ±0 

Results for commit b9f3c8c. ± Comparison against base commit 79c9289.

This pull request removes 9 and adds 4003 tests. Note that renamed tests count towards both. 
cpp_int_conversion ‑ from_cpp_int
cpp_int_conversion ‑ to_cpp_int
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
static_tests ‑ base_test_backend_128_256
static_tests ‑ base_test_backend_12_17
static_tests ‑ base_test_backend_260_130

base_operations.even_mod_130 ‑ _0
base_operations.even_mod_130 ‑ _1
base_operations.even_mod_130 ‑ _10
base_operations.even_mod_130 ‑ _100
base_operations.even_mod_130 ‑ _101
base_operations.even_mod_130 ‑ _102
base_operations.even_mod_130 ‑ _103
base_operations.even_mod_130 ‑ _104
base_operations.even_mod_130 ‑ _105
base_operations.even_mod_130 ‑ _106
…

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Gcc Test Results

  158 files   -     1    158 suites   - 1   16m 39s ⏱️ -57s
7 075 tests +3 994  7 069 ✅ +3 994  6 💤 ±0  0 ❌ ±0 
7 159 runs  +3 990  7 153 ✅ +3 990  6 💤 ±0  0 ❌ ±0 

Results for commit b9f3c8c. ± Comparison against base commit 79c9289.

This pull request removes 9 and adds 4003 tests. Note that renamed tests count towards both. 
cpp_int_conversion ‑ from_cpp_int
cpp_int_conversion ‑ to_cpp_int
lpc_math_polynomial_suite ‑ lpc_basic_skipping_layers_test
lpc_math_polynomial_suite ‑ lpc_dfs_basic_test
lpc_params_test_suite ‑ lpc_batches_num_3_test
lpc_params_test_suite ‑ lpc_different_hash_types_test
static_tests ‑ base_test_backend_128_256
static_tests ‑ base_test_backend_12_17
static_tests ‑ base_test_backend_260_130

base_operations.even_mod_130 ‑ _0
base_operations.even_mod_130 ‑ _1
base_operations.even_mod_130 ‑ _10
base_operations.even_mod_130 ‑ _100
base_operations.even_mod_130 ‑ _101
base_operations.even_mod_130 ‑ _102
base_operations.even_mod_130 ‑ _103
base_operations.even_mod_130 ‑ _104
base_operations.even_mod_130 ‑ _105
base_operations.even_mod_130 ‑ _106
…

♻️ This comment has been updated with latest results.

@ioxid ioxid force-pushed the multiprecision-refactoring-step-2 branch 4 times, most recently from f022aa0 to cbf94ae Compare December 16, 2024 09:52
ioxid added 16 commits December 16, 2024 12:25
@ioxid
multiprecision: restructure directories
d0a78f5
@ioxid
multiprecisoin: simplify intel_intrinsics.hpp
989f3c5
@ioxid
multiprecision: fix pow(..., INT_MIN)
6a5028f
@ioxid
multiprecision: rename exp to pow
25fcecc
@ioxid
multiprecision: big_uint: add std::hash specialization
28d1735
@ioxid
multiprecision: big_uint: refactor comparision operators
abbf0e0
@ioxid
multiprecision: big_mod: refactor comparision operators
1e35c58
@ioxid
multiprecision: big_uint: make used_limbs() and order() private
a598970
@ioxid
multiprecision: big_uint: fix increment
3f0850a
@ioxid
multiprecision: fix spelling
5e2bfec
@ioxid
multiprecision: big_uint: refactor operators
eff0f30
@ioxid
multiprecision: test: enable some tests
9020421
@ioxid
multiprecision: test: use generated data in tests
243e26d
@ioxid
multiprecision: big_uint: remove cpp_int_conversions.hpp and tests
4f8293b
@ioxid
multiprecision: cleanup
9c9cdb1
@ioxid
multiprecision: big_mod: refactor
c37ea13
@ioxid ioxid force-pushed the multiprecision-refactoring-step-2 branch 2 times, most recently from e95de6b to c37ea13 Compare December 16, 2024 12:10
@ioxid ioxid requested a review from martun December 16, 2024 15:20
@ioxid ioxid marked this pull request as ready for review December 16, 2024 15:22
@ioxid ioxid force-pushed the multiprecision-refactoring-step-2 branch from eab7df5 to b9f3c8c Compare December 16, 2024 16:09
@martun martun added this pull request to the merge queue Dec 16, 2024
Merged via the queue into master with commit 84338fd Dec 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martun martun martun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioxid @martun