proof-producer: add exp traces to zkevm circuit #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang Test Results 164 files ±0 164 suites ±0 15m 36s ⏱️ +4s Results for commit 9b7954c. ± Comparison against base commit 04a9a94. This pull request removes 4 tests.♻️ This comment has been updated with latest results. |
akokoshn
reviewed
Dec 23, 2024
proof-producer/libs/assigner/include/nil/proof-generator/assigner/trace_parser.hpp
Outdated
Show resolved
Hide resolved
proof-producer/libs/assigner/include/nil/proof-generator/assigner/trace_parser.hpp
Outdated
Show resolved
Hide resolved
x-mass
force-pushed
the
exp-traces
branch
2 times, most recently
from
8b8e1ce to
a3c1551
Compare
akokoshn
reviewed
Jan 7, 2025
proof-producer/libs/assigner/include/nil/proof-generator/assigner/assigner.hpp
Outdated
Show resolved
Hide resolved
proof-producer/libs/assigner/include/nil/proof-generator/assigner/trace_parser.hpp
Show resolved
Hide resolved
makxenov
reviewed
Jan 7, 2025
proof-producer/libs/assigner/include/nil/proof-generator/assigner/bytecode.hpp
Outdated
Show resolved
Hide resolved
proof-producer/libs/assigner/include/nil/proof-generator/assigner/trace_parser.hpp
Outdated
Show resolved
Hide resolved
proof-producer/libs/assigner/include/nil/proof-generator/assigner/zkevm.hpp
Show resolved
Hide resolved
x-mass
force-pushed
the
exp-traces
branch
2 times, most recently
from
6dd36ac to
2c2879b
Compare
akokoshn
approved these changes
Jan 8, 2025
akokoshn
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't check actual exp traces proving, since now zkevm circuit fails on SLOAD operation. We should add power operation to simple contract and test it after zkevm fix.