Use multithreaded assigner #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyMlashkin
force-pushed
the
use-multithreaded-assigner
branch
from
53bf865 to
bcdcfed
Compare
akokoshn
requested changes
Oct 3, 2024
...pto3/libs/parallel-containers/include/nil/parallel-crypto3/container/accumulation_vector.hpp
Show resolved
Hide resolved
...lel-crypto3/libs/parallel-containers/include/nil/parallel-crypto3/container/merkle/proof.hpp
Show resolved
Hide resolved
...llel-crypto3/libs/parallel-containers/include/nil/parallel-crypto3/container/merkle/tree.hpp
Show resolved
Hide resolved
...s/parallel-zk/include/nil/parallel-crypto3/zk/commitments/detail/polynomial/eval_storage.hpp
Show resolved
Hide resolved
.../include/nil/parallel-crypto3/zk/commitments/detail/polynomial/powers_of_tau/accumulator.hpp
Show resolved
Hide resolved
...k/include/nil/parallel-crypto3/zk/commitments/detail/polynomial/powers_of_tau/public_key.hpp
Show resolved
Hide resolved
.../parallel-zk/include/nil/parallel-crypto3/zk/commitments/detail/polynomial/proof_of_work.hpp
Show resolved
Hide resolved
...l/parallel-crypto3/zk/commitments/detail/polynomial/r1cs_gg_ppzksnark_mpc/crs_operations.hpp
Show resolved
Hide resolved
I don't think it's possible. Because, come of the includes should still point to the single-threaded implementation. |
AndreyMlashkin
force-pushed
the
use-multithreaded-assigner
branch
from
4d876fe to
d3aae4c
Compare
AndreyMlashkin
force-pushed
the
use-multithreaded-assigner
branch
from
03a1de6 to
3b88949
Compare
akokoshn
requested changes
Oct 7, 2024
| @@ -47,6 +47,7 @@ function(setup_proof_generator_target) | |||
| if(ARG_ADDITIONAL_DEPENDENCIES) | |||
| foreach(lib IN LISTS ARG_ADDITIONAL_DEPENDENCIES) | |||
| target_link_libraries(${ARG_TARGET_NAME}-lib INTERFACE ${lib}) | |||
| target_compile_definitions(${ARG_TARGET_NAME}-lib INTERFACE MULTITHREADED) | |||
There was a problem hiding this comment.
check if lib is parallel-crypto3.
Generally single-thread version also can has some additional dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.