Split transpiler tests, add KZG tests #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioxid
force-pushed
the
split-transpiler-tests
branch
from
9c01bb6 to
091f406
Compare
ETatuzova
requested changes
Oct 4, 2024
ETatuzova
reviewed
Oct 4, 2024
ioxid
force-pushed
the
split-transpiler-tests
branch
from
8456f13 to
176f615
Compare
|
I found that verifier printer parameters in tests are incorrect, because the comments mention wrong parameters. This is probably a result of some refactoring. Since I don't know what these parameters mean I don't really know what should be there. But it can break in unexpected ways. (notice that 15 is passed for an optional boolean parameter, and two other parameter names don't match) |
|
@ETatuzova Added deployable contract generation. Also see a comment above about wrong transpiler parameters in LPC tests. |
ETatuzova
approved these changes
Oct 8, 2024
ioxid
force-pushed
the
split-transpiler-tests
branch
from
286f89e to
522b9fa
Compare
ETatuzova
approved these changes
Oct 8, 2024
ioxid
force-pushed
the
split-transpiler-tests
branch
from
295db2a to
59342a0
Compare
ETatuzova
approved these changes
Oct 8, 2024
ioxid
force-pushed
the
split-transpiler-tests
branch
from
59342a0 to
7070854
Compare
ioxid
force-pushed
the
split-transpiler-tests
branch
from
7070854 to
157ca4a
Compare
ETatuzova
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.