42 dfri recursive component #66
Conversation
| row++; | ||
| } | ||
|
|
||
| std::vector<std::pair<std::size_t, std::size_t>> ordered_eval_map; |
There was a problem hiding this comment.
Move it to constructor
There was a problem hiding this comment.
Moved to dFRI component constructor
| witnesses.push_back(component.W(i)); | ||
| } | ||
|
|
||
| dfri_linear_check_component_type dfri_linear_check_instance = dfri_linear_check_component_type(witnesses, std::array<std::uint32_t, 1>(), std::array<std::uint32_t, 0>(), ordered_eval_map.size(), ordered_eval_map); |
There was a problem hiding this comment.
Move component instance constructor to dFRI verifier constructor
There was a problem hiding this comment.
Moved to dFRI component constructor
| x_indices.push_back(x_index_output.b0); | ||
| } | ||
|
|
||
| std::vector<var> negative_xs; |
There was a problem hiding this comment.
There is no need to use lambda rows for it.
Place pairs {x, -x} horizontally
There was a problem hiding this comment.
flexible_negate component created for this part
| const auto &constant_pow2_instance = component.constant_pow2_instance; | ||
| const auto &x_index_instance = component.x_index_instance; | ||
| const auto &colinear_checks_instance = component.colinear_checks_instance; | ||
| // const auto &dfri_linear_check_instance = component.dfri_linear_check_instance; |
There was a problem hiding this comment.
Why is it commented?
| x_indices.push_back(x_index_output.b0); | ||
| } | ||
|
|
||
| std::vector<var> negative_xs; |
There was a problem hiding this comment.
Same with similar comment in generate_assignments.
Place pairs horizontally
There was a problem hiding this comment.
flexible_negate component added for this operation
| row++; | ||
| } | ||
|
|
||
| std::vector<std::pair<std::size_t, std::size_t>> ordered_eval_map; |
There was a problem hiding this comment.
No need in code duplication. Move to constructor.
There was a problem hiding this comment.
Moved to dFRI component constructor
| witnesses.push_back(component.W(i)); | ||
| } | ||
|
|
||
| dfri_linear_check_component_type dfri_linear_check_instance = dfri_linear_check_component_type(witnesses, std::array<std::uint32_t, 1>(), std::array<std::uint32_t, 0>(), ordered_eval_map.size(), ordered_eval_map); |
There was a problem hiding this comment.
Move to dFRI component constructor
There was a problem hiding this comment.
Moved to dFRI component constructor
No description provided.