Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/Add basic UI #4

Merged
merged 9 commits into from
Sep 1, 2023
Merged

feature/Add basic UI #4

merged 9 commits into from
Sep 1, 2023

Conversation

NitBravoA92
Copy link
Owner

@NitBravoA92 NitBravoA92 commented Sep 1, 2023

🚩Milestone 4: Add basic UI | add-basic-ui - >>branch<< -

Hi there! @NitBravoA92 here. 👋

This is the PR for the OOP school library: Add basic UI activity. The main objective of this Milestone is: to create the main user interface for the command line and the different functionalities that will be offered to the user when he selects each menu option: List books, List people (Students and Teachers), List rents, Create a book, Create a person (Student or Teacher), Create a rent and List the rents by Person ID.

Here is a summary of what has been done:

  • Add a new intance variable: type in the Person class.

  • Create the App class with four instance variables: @title, @books_list, @people_list, @rentals_list, and the methods:
    list_books: List all the books created by the user
    list_people: List all the people (Students and Teachers) created by the user
    list_rentals: List all the book rentals created by the user
    create_person: Allows users add a new person (student or teacher)
    create_book: Allows users add a new book
    create_rental: Allows users add a new book rental
    menu_options: This method has the code to display the list of application menu options
    menu: This method has the logic to display the whole menu and process the options selected by the user
    run: This method starts the application
    list_books_for_rental: This private method displays the list of books in the Create a rental option
    list_people_for_rental: This private method displays the list of people in the Create a rental option
    create_student: This private method has the logic to add a new student to the @people_list array
    create_teacher: This private method has the logic to add a new teacher to the @people_list array

  • Create the main method in the main.rb file with the code to run the application

  • Remove the run.rb file

  • Update the README.md file

⭐To the code reviewer 👨‍💻

💝 I really thank 🙇‍♂️ you, dear code reviewer 👨‍🎨 for dedicating your precious 🥇 time ⌚ to check the PR 🧾 .

I kindly ask 🙏 dear code reviewer 🤵 that if there is any kind of issue 🦯 in this project, please do list 📃 them in a descriptive 💡 manner and give your best suggestions 🎁 if needed.

If you think some big issues are essential to be changed ♻️ please kindly contact 📞 me through Zoom or Slack, I am available on Microverse UTC-6 time zone.

@NitBravoA92 NitBravoA92 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 1, 2023
Copy link

@roshan-bajgain roshan-bajgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NitBravoA92,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors. ✔️
  • Gitflow is followed. ✔️
  • Add basic UI ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NitBravoA92 NitBravoA92 merged commit 6441ed2 into dev Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants