feature/Refactor your code #5
Conversation
There was a problem hiding this comment.
Approved ✔
Hi @NitBravoA92 and @ahmedeid6842,
Great job, Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
(Highlights) Good Points: 👍
- Your work is well documented. ✔
- The correct workflow is used. ✔
- All linters checks are ok. ✔
(Changes Required) Aspects to improve: ♻️
- N/A
[Optional] suggestions:
- N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
**Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
@Omar-Muhamad By the way Alex is one of my top picks for cities to visit. 😆 ❤️ |
🚩Milestone 5: Refactor your code | refactor - >>branch<< -
Hi there! @NitBravoA92 and @ahmedeid6842 here. 👋
This is the PR for the Refactor your code activity. The main objective of this Milestone is to refactor the application code, to make it much cleaner and more maintainable by applying the SOLID principle and the best practices in development with Ruby
Here is a summary of what has been done:
Modify the
Appclass, to delegate only the responsibility of processing the logic of the application. For this, all requests for information made to the user and other user's interactions were eliminated (for example: Request data to create or list information on people and income). Now the class has clearer responsibilitiesCreate the
UserInterfaceActionsclass, which implements all the interactions that the user will have with the application, such as requesting and entering information to create people, books, and rentals, and also displaying the list of books, people, and rentalsModify the
mainmethod of the main.rb file so that it contains the code needed to start the application. For that, an instance of the App class and an instance of the UserInterfaceActions class have been created and when themenumethod of this class is called, the application begins its execution.Update the README.md file
⭐To the code reviewer 👨💻
💝 We really thank 🙇♂️ you, dear code reviewer 👨🎨 for dedicating your precious 🥇 time ⌚ to check the PR 🧾 .
We kindly ask 🙏 dear code reviewer 🤵 that if there is any kind of issue 🦯 in this project, please do list 📃 them in a descriptive 💡 manner and give your best suggestions 🎁 if needed.
If you think some big issues are essential to be changed ♻️ please kindly contact 📞 us through Zoom or Slack, We're available on Microverse UTC-6 time zone.