-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/Create unit tests #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Team 😃,
Your project is complete! There is nothing else to say other than... It's time to merge it
Congratulations! 🎉
Highlights
Cheers, and Happy coding!👏👏👏
- Great job installing the required gem for testing
- Great file structure
- Well done testing each of the classes
- Nice work using describe and context keywords properly
- All the tests are passing ✔️
- Excellent communication with the reviewer. Thank you ❤️
- Descriptive PR and README
- Correct Linters
Feel free to mention @MahmoudBakr23 to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
🚩Milestone 7: create unit tests | unit_test - >>branch<< -
Hi there! @NitBravoA92 and @ahmedeid6842 here. 👋
This is the PR for the create unit tests activity. The main objective of this Milestone is to learn how to how to write unite testing function by the help of
rspec
Here is a summary of what has been done:
create the following test cases for
Book
classid
,title
,author
and emptyrentals
of the new bookRental
class to the rentals array.to_json
method.create the following test cases for
CapitalizeDecorator
classCapitalizeDecorator
object.create the following test cases for
Classroom
classcreate the following test cases for
Decorator
classcreate the following test cases for the
Nameable
classcreate the following test cases for the
Person
classid
,name
,age
of the new person.create the following test cases for the
Rental
classid
,date
,book
,teacher
of the new rental.create the following test cases for the
Student
classid
,classroom
,age
,name
of the new student.create the following test cases for the
Teacher
classid
,specialization
,age
,name
of the new teacher.⭐To the code reviewer 👨💻
💝 We really thank 🙇♂️ you, dear code reviewer 👨🎨 for dedicating your precious 🥇 time ⌚ to check the PR 🧾 .
We kindly ask 🙏 dear code reviewer 🤵 that if there is any kind of issue 🦯 in this project, please do list 📃 them in a descriptive 💡 manner and give your best suggestions 🎁 if needed.
If you think some big issues are essential to be changed ♻️ please kindly contact 📞 us through Zoom or Slack, We're available on Microverse UTC-6 time zone.