Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDD project/unit test #1

Merged
merged 10 commits into from
Sep 8, 2023
Merged

TDD project/unit test #1

merged 10 commits into from
Sep 8, 2023

Conversation

NitBravoA92
Copy link
Owner

🚩Write unit tests applying TDD methodology | write-unit-tests - >>branch<< -

Hi there! @NitBravoA92 👋

This is the PR for the TDD project activity. The main objective of this project is to learn how to work with the TDD methodology in a software development project to improve the code structure and quality and speed up the development process.

Here is a summary of what has been done:

  • Create the following test cases for the factorial method of the Solver class:

    • Test when the method receives 0 as an argument and should return 1
    • Test when the method receives 10 as an argument and should return 3.628.800
    • Test when the method receives -4 as an argument and should return an exception Invalid input
    • Test when the method receives 3 as an argument and should return 6
  • Create the following test cases for the reverse method of the Solver class:

    • Test when the method receives the hello word as an argument and should return olleh
    • Test when the method receives the developer word as an argument and should return repoleved
  • Create the following test cases for the fizzbuzz method of the Solver class:

    • Test when the method receives 15 as an argument and should return the fizzbuzz word
    • Test when the method receives 30 as an argument and should return the fizzbuzz word
    • Test when the method receives 6 as an argument and should return the fizz word
    • Test when the method receives 25 as an argument and should return the buzz word
    • Test when the method receives 7 as an argument and should return the number '7' as a string
    • Test when the method receives 13 as an argument and should return the number '13' as a string
  • Create the Solver class and the methods:

    • factorial that receives a positive integer and returns the factorial of the given number,
    • reverse that receives a string and returns the reverse word of the given string
    • fizzbuzz that receives a positive integer and returns "fizz" if the given number is divisible by 3, "buzz" if the given number is divisible by 5, and "fizzbuzz" if the given number is divisible by both 3 and 5. If the given number is not divisible by 3 or 5, the method returns the given number as a string.
  • Add the README file to document the project

⭐To the code reviewer 👨‍💻

💝 I really thank 🙇‍♂️ you, dear code reviewer 👨‍🎨 for dedicating your precious 🥇 time ⌚ to check the PR 🧾 .

I kindly ask 🙏 dear code reviewer 🤵 that if there is any kind of issue 🦯 in this project, please do list 📃 them in a descriptive 💡 manner and give your best suggestions 🎁 if needed.

If you think some big issues are essential to be changed ♻️ please kindly contact 📞 me through Zoom or Slack, I am available on Microverse UTC-6 time zone.

giphy

@NitBravoA92 NitBravoA92 self-assigned this Sep 8, 2023
@NitBravoA92 NitBravoA92 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 8, 2023
Copy link

@AndreaM2429 AndreaM2429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approve! 🥳🥳

Hi @NitBravoA92, your project is complete so it's time to merge it. 🎆

CONGRATS

Highlights ✨

  • Descriptive PR
  • Gitflow
  • All test passing
  • Clean and organize code

@NitBravoA92
Copy link
Owner Author

@AndreaM2429 Thank you so much for taking the time to review and approve my Pull Request

@NitBravoA92 NitBravoA92 merged commit 1a12e93 into dev Sep 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants