Add device information, media player entities, some refactoring #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esgrove
approved these changes
Sep 9, 2024
|
Thanks for the thorough review, I'll incorporate some of the suggested changes! Like you suspected, some stuff is done in a particular way because that's how Home Assistant expects you to do it. I'm by no means an expert on making these integrations either though, so there may be more than one way to do things. |
|
Will do a smoke test before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying a new approach regarding connection handling, i.e. use ephemeral connections to fetch data. This way we don't need to handle reconnects etc.