Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust improvements #331

Merged
merged 12 commits into from
Jan 15, 2024
Merged

Rust improvements #331

merged 12 commits into from
Jan 15, 2024

Conversation

Esgrove
Copy link
Contributor

@Esgrove Esgrove commented Jan 12, 2024

  • Add AWS_REGION env variable option
  • Simplify anyhow context usage
  • Sort std imports and third-party crates separately
  • Bump rust project version, first to 0.5.0 to match crates.io and then 0.6.0 due to new env variable option
  • Update clap and some other dependencies

@Esgrove Esgrove requested a review from kahlstrm January 12, 2024 10:30
kahlstrm
kahlstrm reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@kahlstrm kahlstrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 we can do this as a patch in my opinion as the behavior doesn't change, otherwise good to merge

rust/src/cli.rs
Comment on lines +25 to +26
/// Specify AWS region for the bucket
#[arg(short, long, env = "AWS_REGION")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, how does this work aka which gets priority. E.g. AWS_REGION=eu-west-1 vault --region eu-central-1 lookup secret, which one is the one that is used? I'd assume it's the flag one, but unsure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, works as expected, the command above targets eu-central-1

rust/Cargo.toml Outdated Show resolved Hide resolved
@Esgrove @kahlstrm
change to patch version update
abfb8ab 
Co-authored-by: Kalle Ahlström <[email protected]>
@Esgrove Esgrove merged commit f9a22eb into master Jan 15, 2024
9 checks passed
@Esgrove Esgrove deleted the rust-improvements branch January 15, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kahlstrm kahlstrm kahlstrm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Esgrove @kahlstrm