Skip to content

Commit

Permalink
PinUi: fix recursion issue
Browse files Browse the repository at this point in the history
remember - don't try to overwrite Qt's `.connect` method!
  • Loading branch information
daringer committed Dec 7, 2023
1 parent aa2a43e commit 0c02f61
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion nitrokeyapp/secrets_tab/ui.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def choose(self) -> None:
else:
self.cancelled.emit()

def connect(
def connect_actions(
self,
queried: Optional[Callable[[str], None]],
chosen: Optional[Callable[[str], None]],
Expand Down
2 changes: 1 addition & 1 deletion nitrokeyapp/secrets_tab/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def __init__(
self.query_pin.connect(pin_ui.query)
self.choose_pin.connect(pin_ui.choose)

self.pin_ui = pin_ui.connect(
self.pin_ui = pin_ui.connect_actions(
self.pin_queried,
self.pin_chosen,
lambda: self.pin_verified.emit(False),
Expand Down

0 comments on commit 0c02f61

Please sign in to comment.