Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing UI resource files #163

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Fix missing UI resource files #163

merged 2 commits into from
Nov 9, 2023

Conversation

mmerklinger
Copy link
Collaborator

This PR includes the dynamically created *.py files in nitrokeyapp/ui into the wheel and source archive uploaded to Pypi.

  • The build command of flit only includes files checked in to the VCS. The default is changed with option --no-use-vcs.
  • The Pypi pipeline was executing the command without the above option as well. This change makes it use the Makefile build target.

Fixes #162

@mmerklinger mmerklinger added the cicd Improvements or additions to CICD label Nov 9, 2023
@mmerklinger mmerklinger self-assigned this Nov 9, 2023
@mmerklinger mmerklinger merged commit a991314 into main Nov 9, 2023
8 checks passed
@mmerklinger mmerklinger deleted the fix-missing-ui-resource-files branch November 9, 2023 15:54
@brevilo brevilo mentioned this pull request Dec 5, 2023
Closed
@daringer daringer mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes

Assignees

@mmerklinger mmerklinger

Labels
cicd Improvements or additions to CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pypi] nitrokeyapp package lacks compiled *.ui resources
2 participants
@mmerklinger @robin-nitrokey