Skip to content

Commit

Permalink
Add comment explaining LIBMOUNT_FORCE_MOUNT2=always
Browse files Browse the repository at this point in the history
  • Loading branch information
Ericson2314 committed Apr 8, 2024
1 parent e73dc0e commit bd7c26b
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions tests/functional/local-overlay-store/common.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
source ../common.sh

# The new Linux mount interface does not seem to support remounting
# OverlayFS mount points.
#
# It is not clear whether this is intentional or not:
#
# The kernel source code [1] would seem to indicate merely remounting
# while *changing* mount options is now an error because it erroneously
# succeeded (by ignoring those new options) before. However, we are
# *not* trying to remount with changed options, and are still hitting
# the failure when using the new interface.
#
# For further details, see these `util-linux` issues:
#
# - https://github.com/util-linux/util-linux/issues/2528
# - https://github.com/util-linux/util-linux/issues/2576
#
# In the meantime, setting this environment variable to "always" will
# force the use of the old mount interface, keeping the remounting
# working and these tests passing.
#
# [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/overlayfs/params.c?id=3006adf3be79cde4d14b1800b963b82b6e5572e0#n549
export LIBMOUNT_FORCE_MOUNT2=always

requireEnvironment () {
Expand Down

0 comments on commit bd7c26b

Please sign in to comment.