Flakify the system #189
Flakify the system #189
Conversation
This should hopefully make it easy to move the builds of this machine's config to hydra.nixos.org and its boot process to the nix-netboot-serve instance on netboot.nixos.org.
|
It would be great if we could keep the current deploy setup working in this transition period... https://buildkite.com/grahamc/nix-community-aarch64-build-box/builds/835 |
|
The Hydra jobset is already up and building, does there need to be a transition period? https://hydra.nixos.org/eval/1805747 |
|
I guess my stance is: it'd be nice to be able to keep the "old" way working in case the "new" way doesn't, because I'd like to keep ofborg's aarch64-linux CI working. If you aren't worried about this new setup causing issues then 🤷 guess it's unnecessary. |
| @@ -210,7 +177,13 @@ in makeNetboot { | |||
| environment.etc.host-nix-channel.source = pkgs.path; | |||
| }) | |||
|
|
|||
| ({pkgs, ...}: { | |||
| { | |||
| options.ofborg.package = lib.mkOption { | |||
There was a problem hiding this comment.
a little bit strange that this lib is from outer scope, and why an inline module in imports here instead of putting it directly in the module below?
it does match the surrounding code style, just feels really weird.
There was a problem hiding this comment.
Yeah all these little modules should probably either be smooshed together or moved into their own files.
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
heck yeah 14 line flake. you love to see it honestly.
|
@cole-h we haven't destroyed the old machine, we can revert the relevant commits and set the netboot URL back if this goes wrong. |
This should hopefully make it easy to move the builds of this machine's config to hydra.nixos.org and its boot process to the nix-netboot-serve instance on netboot.nixos.org.
Related: NixOS/infra#416