Upgrade to Nix 2.19 #1314
Merged
Upgrade to Nix 2.19 #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flake lock file updates:
• Updated input 'nix':
'github:NixOS/nix/f5f4de6a550327b4b1a06123c2e450f1b92c73b6' (2023-10-02)
→ 'github:NixOS/nix/50f8f1c8bc019a4c0fd098b9ac674b94cfc6af0d' (2023-11-27)
Ericson2314
commented
Dec 1, 2023
Comment on lines
+267
to
+275
| ServeProto::ReadConn rconn { | ||
| .from = from, | ||
| .version = remoteVersion, | ||
| }; | ||
| ServeProto::WriteConn wconn { | ||
| .to = to, | ||
| .version = remoteVersion, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Moved down because we don't know the versions until after the handshake
Ericson2314
commented
Dec 1, 2023
Comment on lines
+72
to
+76
| void isExecutable() override | ||
| { } | ||
|
|
||
| void closeRegularFile() override | ||
| { } |
There was a problem hiding this comment.
These when from being such empty functions in the interface to = 0 virtual pure ones, so putting the old do-nothing implementations here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1308, which we should definitely merge first (and not skip a Nix release).