Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nar endpoint for binary cache hosting #1414

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

cleverca22
Copy link
Contributor

No description provided.

cleverca22 and others added 2 commits September 20, 2024 04:08
These are required for the `signString` and `readFile` subroutines used when signing NARs.

(cherry picked from commit b94a7b6)
@Mic92 Mic92 merged commit 73e51b9 into NixOS:nix-2.21 Sep 20, 2024
1 check passed
@Mindavi
Copy link
Contributor

Mindavi commented Oct 14, 2024

So, I'm now seeing the following log line pop up in my hydra logs:

Oct 13 19:46:33 nixos-asus hydra-evaluator[3276289]: Couldn't require Hydra::Plugin::S3Backup : Global symbol "$MACHINE_LOCAL_STORE" requires explicit package name (did you forget to declare "my $MACHINE_LOCAL_STORE"?) at /nix/store/2r0v1zjwfbl25p6rl109rv7ai5ssmh5x-hydra-0-unstable-2024-09-24-mindavi/libexec/hydra/lib/Hydra/Plugin/S3Backup.pm line 95.
Oct 13 19:46:33 nixos-asus hydra-evaluator[3276289]: Compilation failed in require at /nix/store/zklv83xga1w14g6zll3910zabks0az7d-hydra-perl-deps/lib/perl5/site_perl/5.38.2/Module/Runtime.pm line 314.
Oct 13 19:46:33 nixos-asus hydra-evaluator[3276289]:  at /nix/store/zklv83xga1w14g6zll3910zabks0az7d-hydra-perl-deps/lib/perl5/site_perl/5.38.2/Module/Pluggable.pm line 32.

I feel something's not completely going as it's supposed to go.

Also seems to have happened in the build here: https://github.com/NixOS/hydra/actions/runs/10958105848/job/30427640890#step:4:7743

Complete log (with an unrelated fail, don´t mind that, memory pressure on the machine):
7w6f7lql4vz21wn4wbghkwr2xvcca5fy-hydra-0-unstable-2024-10-08.drv.log

@Mic92
Copy link
Member

Mic92 commented Oct 15, 2024

Does adding S3Backup to use Nix::Store; fixes it?

Mindavi added a commit to Mindavi/nixos-configuration that referenced this pull request Oct 17, 2024
@Mindavi
Copy link
Contributor

Mindavi commented Oct 17, 2024

No, does not seem to help anything.

Mindavi added a commit to Mindavi/hydra that referenced this pull request Oct 17, 2024
… undefined

See NixOS#1414 (comment)

The variable is defined in src/lib/Hydra/Helper/Nix.pm

Error message without this patch:

```
hydra-evaluator[PID]: Couldn't require Hydra::Plugin::S3Backup : Global symbol "$MACHINE_LOCAL_STORE" requires explicit package name (did you forget to declare "my $MACHINE_LOCAL_STORE"?) at /nix/store/xxx-hydra-0-unstable-2024-09-24/libexec/hydra/lib/Hydra/Plugin/S3Backup.pm line 95.
hydra-evaluator[PID]: Compilation failed in require at /nix/store/xxx-hydra-perl-deps/lib/perl5/site_perl/5.38.2/Module/Runtime.pm line 314.
hydra-evaluator[PID]:  at /nix/store/xxx-hydra-perl-deps/lib/perl5/site_perl/5.38.2/Module/Pluggable.pm line 32.
```
@Mindavi
Copy link
Contributor

Mindavi commented Oct 17, 2024

@Mic92 I found what to do and made a PR that fixes it. Applied this locally and that seems to work, made a PR with that fix too. Thanks for the hint, it helped looking at the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants