Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra context in the nested string interpolation example #1070

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

ellyxir
Copy link
Contributor

@ellyxir ellyxir commented Oct 31, 2024

the string + operator was not previously introduced and it wasn't clear that you can have more than just a variable within ${}
im doing a video series for learning the nix programming language and when i saw this part of the language tutorial, i had a hard time parsing what i was seeing. perhaps this could make it more clear. thank you!

…e the string + operator was not previously introduced
@ellyxir ellyxir requested a review from a team as a code owner October 31, 2024 15:48
@fricklerhandwerk
Copy link
Collaborator

Yeah the tutorial is deliberately not going into depth about operators, because they're largely unsurprising -- except of course for string/path concatenation.

Thanks for pointing it out.

Instead of prefixing the note,
I suggest moving it into a collapsible "detailed explanation" block like it's done elsewhere, and link to the right place in the Nix manual for details on that particular operator.

Could you please do that? If not, I'll keep a reminder to finish it up.

@ellyxir
Copy link
Contributor Author

ellyxir commented Oct 31, 2024

Yes I'd be happy to but won't get to it until Monday. Hope that's ok!

…e because the string + operator was not previously introduced"

This reverts commit 2648f98.
…ngs as operators have no yet been mentioned. link to manual for more operators
@ellyxir
Copy link
Contributor Author

ellyxir commented Nov 2, 2024

I've moved it to a detailed explanation block and added a little more detail. Also linked to manual and the functional libraries section because standard operators and functions are mentioned there. Let me know if this is ok. Thank you!

Copy link
Collaborator

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ellyxir. This prompted me to fix a small discoverability issue in the Nix manual.

I expanded a bit on the explanation.

source/tutorials/nix-language.md Outdated Show resolved Hide resolved
@fricklerhandwerk fricklerhandwerk enabled auto-merge (squash) November 3, 2024 11:56
auto-merge was automatically disabled November 7, 2024 13:12

Head branch was pushed to by a user without write access

@fricklerhandwerk fricklerhandwerk merged commit ac38abe into NixOS:master Nov 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants