-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mutable shortlinks #830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This needs a
niv update
, otherwise the build fails with:
Build finished. The HTML pages are in build/html.
installing
sed: can't read /nix/store/yabz0xx6iyd3h5ba6mv30g7gsjgyqhff-source/doc/manual/_redirects: No such file or directory
error: boost::bad_format_string: format-string is ill-formed
- The new links on this page are a 404
I'd be happy to pick this up if you're too busy atm.
Also, sorry for leaving a ❌ review on a draft, realized after the fact it could've just been a comment 😅 |
As mentioned in the top post, I let it rot waiting for an up-to-date Hydra build to happen. Otherwise we have to build Nix locally. If all versions are in the cache, I can update the pin. |
@fricklerhandwerk I ran it locally and it took a few secs, so yes pretty sure they are. |
Would be great if you can finish it, but otherwise I'll pick it up once I get back to it. |
this allows mapping cleanly from the existing mutable links on nixos.org
a270f2b
to
d6b29c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It still looks like Nix 2.13 needs to be built locally:
|
I can reproduce with https://hydra.nixos.org/eval/1803459 shows that the Hydra build succeeded, but it produces different store paths than the local evaluation:
|
@fricklerhandwerk I think I figured it out, and it's very cursed! Clearing the Nix cache makes it work for me:
And if that also works for you please comment in NixOS/nix#9905 Here's the details:
And here's the kicker, and this is a bit of speculation: You can't check that it works with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, those curses are completely unrelated to this PR here, so this PR is looking good.
Wow, thanks a lot for digging into it. I had already slated to |
closes #843
this allows mapping cleanly from the existing mutable links on nixos.org