Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore: ignore historical test binaries #10085

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

ShamrockLee
Copy link
Contributor

Motivation

After #8886, previously-built test executables are now tracked by Git, which might pollute the development environment and might be staged and committed into the source tree by accident.

Context

This patch add .gitignore rules to ignore the obsolete test directories to solve such problem and enhance developer experience.

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

After commit 91b6833 (" Move tests to separate directories, and
document"), previously-built test executables are now tracked by Git,
which is annoying for developers.

This patch add .gitignore rules to ignore the obsolete test directories
to solve such problem and enhance developer experience.
@thufschmitt thufschmitt merged commit cd2d8b6 into NixOS:master Feb 26, 2024
8 checks passed
@ShamrockLee ShamrockLee deleted the ignore-obsolete-testdir branch February 26, 2024 12:11
tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
.gitignore: ignore historical test binaries

(cherry picked from commit cd2d8b6)
Change-Id: Ieb01910ab7722df78d8570ca6e408f1de5839fb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants