-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for subflakes #10089
Draft
edolstra
wants to merge
8
commits into
NixOS:master
Choose a base branch
from
edolstra:relative-flakes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on May 15, 2024
-
Subflakes are flakes in the same tree, accessed in flake inputs via relative paths (e.g. `inputs.foo.url = "path:./subdir"`). Previously these didn't work very well because they would be separately copied to the store, which is inefficient and makes references to parent directories tricky or impossible. Furthermore, they had their own NAR hash in the lock file, which is superfluous since the parent is already locked. Now subflakes are accessed via the accessor of the calling flake. This avoids the unnecessary copy and makes it possible for subflakes to depend on flakes in a parent directory (so long as they're in the same tree). Lock file nodes for relative flake inputs now have a new `parent` field: { "locked": { "path": "./subdir", "type": "path" }, "original": { "path": "./subdir", "type": "path" }, "parent": [ "foo", "bar" ] } which denotes that `./subdir` is to be interpreted relative to the directory of the `bar` input of the `foo` input of the root flake. Extracted from the lazy-trees branch.
Configuration menu - View commit details
-
Copy full SHA for b2be6fe - Browse repository at this point
Copy the full SHA b2be6feView commit details
Commits on May 17, 2024
-
call-flake.nix: Fix relative path resolution
`parentNode.sourceInfo.outPath` does not include the subdir of the parent flake, while `parentNode.outPath` does. So we need to use the latter.
Configuration menu - View commit details
-
Copy full SHA for 49f592d - Browse repository at this point
Copy the full SHA 49f592dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3180671 - Browse repository at this point
Copy the full SHA 3180671View commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 21fc07c - Browse repository at this point
Copy the full SHA 21fc07cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09d7197 - Browse repository at this point
Copy the full SHA 09d7197View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71d4bb8 - Browse repository at this point
Copy the full SHA 71d4bb8View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 91e7d49 - Browse repository at this point
Copy the full SHA 91e7d49View commit details
Commits on Sep 25, 2024
-
tests/functional/flakes/relative-paths.sh: Fix build failure in hydra…
…Jobs.tests.functional_user
Configuration menu - View commit details
-
Copy full SHA for f206325 - Browse repository at this point
Copy the full SHA f206325View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.