GitHub fetcher: Don't emit treeHash yet #10197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But do accept it if it's there, so we don't choke on future lock files that do have the treeHash attribute.
edolstra
added
the
backport 2.20-maintenance
github-actions
bot
added
the
fetching
thufschmitt
approved these changes
Mar 8, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.20-maintenance
git worktree add -d .worktree/backport-10197-to-2.20-maintenance origin/2.20-maintenance
cd .worktree/backport-10197-to-2.20-maintenance
git switch --create backport-10197-to-2.20-maintenance
git cherry-pick -x 6d245182e8900ad86cf767108289afc879293e8c |
edolstra
added a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were emitting
treeHashbut not accepting it. Also, older versions of Nix don't recognize it. So let's not emit it yet (we're not actually checking it anyway). But do accept it if it's there, so we don't choke on future lock files that do have it.Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.