Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvalCache: Fix missing format string argument #10293

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

edolstra
Copy link
Member

Motivation

Fixes

terminate called after throwing an instance of 'boost::wrapexcept<boost::io::too_few_args>'
  what():  boost::too_few_args: format-string referred to more arguments than were passed
Aborted (core dumped)

for type errors in AttrCursor.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Fixes

  terminate called after throwing an instance of 'boost::wrapexcept<boost::io::too_few_args>'
    what():  boost::too_few_args: format-string referred to more arguments than were passed
  Aborted (core dumped)

for type errors in AttrCursor.
@edolstra edolstra added the backport 2.21-maintenance Automatically creates a PR against the branch label Mar 22, 2024
@edolstra
Copy link
Member Author

Note: this issue has existed since 2.13.

@roberth roberth added backport 2.18-maintenance Automatically creates a PR against the branch backport 2.19-maintenance Automatically creates a PR against the branch backport 2.20-maintenance Automatically creates a PR against the branch bug flakes language The Nix expression language; parser, interpreter, primops, evaluation, etc labels Mar 24, 2024
@roberth roberth merged commit f891673 into master Mar 24, 2024
15 checks passed
@roberth roberth deleted the fix-missing-format-arg branch March 24, 2024 01:28
Copy link

Backport failed for 2.18-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.18-maintenance
git worktree add -d .worktree/backport-10293-to-2.18-maintenance origin/2.18-maintenance
cd .worktree/backport-10293-to-2.18-maintenance
git switch --create backport-10293-to-2.18-maintenance
git cherry-pick -x bfd36402acc976c32ec8349a2a25fa4288d65475

Copy link

Backport failed for 2.19-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.19-maintenance
git worktree add -d .worktree/backport-10293-to-2.19-maintenance origin/2.19-maintenance
cd .worktree/backport-10293-to-2.19-maintenance
git switch --create backport-10293-to-2.19-maintenance
git cherry-pick -x bfd36402acc976c32ec8349a2a25fa4288d65475

Copy link

Backport failed for 2.20-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.20-maintenance
git worktree add -d .worktree/backport-10293-to-2.20-maintenance origin/2.20-maintenance
cd .worktree/backport-10293-to-2.20-maintenance
git switch --create backport-10293-to-2.20-maintenance
git cherry-pick -x bfd36402acc976c32ec8349a2a25fa4288d65475

Copy link

Successfully created backport PR for 2.21-maintenance:

@roberth
Copy link
Member

roberth commented Mar 24, 2024

Not asking for a test this time, because of #10294

@thufschmitt
Copy link
Member

@roberth will you handle the backports to 2.19 and 2.18 since the automatic ones failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.18-maintenance Automatically creates a PR against the branch backport 2.19-maintenance Automatically creates a PR against the branch backport 2.20-maintenance Automatically creates a PR against the branch backport 2.21-maintenance Automatically creates a PR against the branch bug flakes language The Nix expression language; parser, interpreter, primops, evaluation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants