Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Treat empty TMPDIR as unset #10303

Merged
merged 6 commits into from
Mar 25, 2024
Merged

fix: Treat empty TMPDIR as unset #10303

merged 6 commits into from
Mar 25, 2024

Commits on Mar 23, 2024

  1. fix: Treat empty TMPDIR as unset 

    Fixes an instance of

    nix: src/libutil/util.cc:139: nix::Path nix::canonPath(PathView, bool): Assertion `path != ""' failed.

... which I've been getting in one of my shells for some reason.
I have yet to find out why TMPDIR was empty, but it's no reason for
Nix to break.
    @roberth
    roberth committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    c3fb2aa View commit details
    Browse the repository at this point in the history

  2. fix: Treat empty XDG_RUNTIME_DIR as unset 

    See preceding commit. Not observed in the wild, but is sensible
and consistent with TMPDIR behavior.
    @roberth
    roberth committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    b9e7f5a View commit details
    Browse the repository at this point in the history

  3. local-derivation-goal.cc: Reuse defaultTempDir()

    @roberth
    roberth committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    fd31945 View commit details
    Browse the repository at this point in the history

  4. local-derivation-goal.cc: Remove *all* trailing slashes

    @roberth
    roberth committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    dd26f41 View commit details
    Browse the repository at this point in the history

  5. HttpBinaryCacheStore: Remove *all* trailing slashes

    @roberth
    roberth committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    850c9a6 View commit details
    Browse the repository at this point in the history

  6. git/dumpTree: Assert name not empty before back()

    @roberth
    roberth committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    3b7f2bf View commit details
    Browse the repository at this point in the history