Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and document builtins.baseNameOf, improve internal baseNameOf() #10306

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

roberth
Copy link
Member

@roberth roberth commented Mar 24, 2024

Motivation

baseNameOf is weird. Deal with it.

Context

Found while at code related to #10303

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@roberth roberth requested a review from edolstra as a code owner March 24, 2024 00:40
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Mar 24, 2024
@Ericson2314
Copy link
Member

FWIW programming language standard libraries tend not to remove any slashes:

Perhaps we will eventually (not now!) migrate our internal baseName to work that way too, e.g. as part of #9205. But totally that agreed removing all trailing slashes is more consistent that removing just one.

@thufschmitt thufschmitt merged commit 1394d4e into NixOS:master Mar 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants