Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in operators #10318

Closed
wants to merge 1 commit into from
Closed

Typo fix in operators #10318

wants to merge 1 commit into from

Conversation

alcalyn
Copy link

@alcalyn alcalyn commented Mar 25, 2024

Motivation

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@alcalyn alcalyn requested a review from edolstra as a code owner March 25, 2024 10:00
@@ -159,7 +159,7 @@ All comparison operators are implemented in terms of `<`, and the following equi

| comparison | implementation |
|--------------|-----------------------|
| *a* `<=` *b* | `! (` *b* `<` *a* `)` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current text looks correct to me. Maybe you expected a and b not to be swapped.

I think they were swapped to reflect that they're not just equivalences, but implementation rules as mentioned in the sentence before the table.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh true, didn't seen that was swapped

@alcalyn alcalyn closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants