patched fromTOML to fix MacOS testing #10332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, where do you see macOS being broken? |
|
has been broken in testing for me for some time. see also >> #10330 |
|
That's weird, it builds on GHA and Hydra. |
its related to the version of boost that is running, and the use of C++20. it seems that on MacOS toml11 doesnt properly recognise its running in C++20 without the use of version.hpp, a file added later on in newer versions of toml11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
currently, compilation on MacOS is broken due to a known issue relating to
std::result_ofbeing removed from c++20. This PR fixes this issue by instructing TOML11 to usestd::invoke_resultMore information can be found via: https://stackoverflow.com/questions/75121130