Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix shell shebang: support O'Caml comments #10337

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

Cyclic4179
Copy link
Contributor

see #10336

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@roberth roberth changed the title fix #10336 nix shell shebang: support O'Caml comments Mar 27, 2024
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lisps might disagree, but they can insert an empty line if they're really concerned about the shebang logic scanning further than necessary.

@edolstra
Copy link
Member

Can you add a test for this in functional/flakes/flakes.sh?

@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Mar 27, 2024
@roberth roberth merged commit ef26133 into NixOS:master Mar 28, 2024
8 checks passed
@roberth
Copy link
Member

roberth commented Mar 28, 2024

Thank you!

@Cyclic4179 Cyclic4179 deleted the patch-1 branch April 1, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants