Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out isRootUser function #10363

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

Ericson2314
Copy link
Member

Motivation

This helps with Windows porting

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store labels Mar 29, 2024
Copy link
Contributor

@puffnfresh puffnfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer. I'm not sure what the plan is for Windows but we can't have uid scattered throughout the code in any case.

@thufschmitt thufschmitt merged commit 845b2a9 into NixOS:master Mar 30, 2024
10 checks passed
@Ericson2314
Copy link
Member Author

Yeah I am not sure what it will be for Windows either, but I also hope this function can be used less and less as special-casing root on Unix is not great either.

@Ericson2314 Ericson2314 deleted the is-root-user branch March 30, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store windows
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants