-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Nix-Perl to Meson #10378
Port Nix-Perl to Meson #10378
Conversation
I think |
the style isnt standard across the codebase, there doesnt seem to be anything to suggest which should be used. |
e939c25
to
e4483f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an inconsistant use of spaces on both sides of :
, I'm partial to the space on each side style, but probably should just pick one or the other and stick with it.
63ea7ac
to
7d9ae33
Compare
For C++ we put the |
I love to see progress on this. Just a small point: could you use the imperative mood instead of past tense in commit messages? |
e3b509f
to
4e74c28
Compare
4e74c28
to
b362a63
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-04-03-nix-team-meeting-135/42962/1 |
@Ericson2314 is this stuck on style alone? |
@roberth Yes, if that is even a blocker. |
style can be fixed trivially, waiting on consensus of whether to merge before investing more time :) |
👍 from me. Based on the notes, while Eelco wasn't convinced, he didn't outright reject it, so I think we should try it. After all, the point of doing a part of the project first is that we can evaluate meson in practice. |
sounds good, ill fix up the style issues and get the pr corrected. |
Yes and now that mesonbuild/meson#13055 is merged, I think all style matters can squarely follow upstream recommendations, rather than me winging it :) |
b362a63
to
aff1058
Compare
aff1058
to
3a251d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I corrected a few small things, and this now has my final approval
For most purposes, the stock `ninja test` should be fine, but this allows for doing other things with the `yath` during development.
3a251d2
to
1ac635d
Compare
Motivation
The current buildsystem impacts Nix portability, and obstructs development of Nix on non GNU/Linux systems. Replacing the buildsystem with meson fixes this, along with adding better access to developer tools (i.e. valgrind).
Context
#3160
NixOS/rfcs#132
#9342
NixOS/nixpkgs#26850