[Backport 2.20-maintenance] Fix adding symlink to the sandbox paths #10471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…o a symlink out of the store Bind-mounting symlinks is apparently not possible, which is why the thing was failing. Fortunately, symlinks are small, so we can fallback to copy them at no cost. Fix #9579 Co-authored-by: Artturin <[email protected]> (cherry picked from commit 913db9f)
github-actions
bot
requested review from
thufschmitt and
edolstra
as code owners
github-actions
bot
added
the
with-tests
|
Need backports of #10362 for this. I kicked that off. (It doesn't make a breaking change to Nix's headers so it should be OK.) |
thufschmitt
force-pushed
the
backport-10456-to-2.20-maintenance
branch
from
af3af23
to
ccb9779
Compare
|
Dropped the last commit, should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic backport to
2.20-maintenance, triggered by a label in #10456.