Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repl completion test #10799

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

roberth
Copy link
Member

@roberth roberth commented May 28, 2024

Motivation

Closes #10784

This uses expect, which I don't like, but it gets the job done, and doesn't require that we add dependencies to existing derivations.

Most repl tests should be done in a DX friendly way in the functional test suite, e.g.

Tab completion would be out of scope for such a test runner.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@roberth roberth requested a review from edolstra as a code owner May 28, 2024 15:01
@roberth roberth mentioned this pull request May 28, 2024
@roberth roberth added repl The Read Eval Print Loop, "nix repl" command and debugger tests labels May 28, 2024
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@Ericson2314 Ericson2314 merged commit 1e2b267 into NixOS:master May 28, 2024
11 checks passed
tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
Add repl completion test

(cherry picked from commit 1e2b267)

Change-Id: Ic3de39e71960a05a8676190b1ec9a7f0bb6057f5
Signed-off-by: Jörg Thalheim <[email protected]>
tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repl The Read Eval Print Loop, "nix repl" command and debugger tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Test repl completions
3 participants