base64Decode: clearer error message when an invalid character is detected (backport #8766) #11519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output the offending string in its entirety to provide context.
Closes #8479
Motivation
I recently had an issue where the public key for a binary cache was pasted incorrectly into the extra substituters section of a
flake.nix
. All I received as error output when attempting to build was:After spending some time trying to bisect the issue I was still unable to determine what change had resulted in the error. That was when @zimbatm and @Mic92 suggested patching
nix
to better explain what was causing the problem.@Mic92 put together this small patch and, after applying it, the underlying issue was immediately apparent since the error message contained the malformed public key entry.
Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 👍 to pull requests you find important.
This is an automatic backport of pull request #8766 done by [Mergify](https://mergify.com).