base64Decode: clearer error message when an invalid character is detected (backport #8766)

[mergify]

Output the offending string in its entirety to provide context.

Closes #8479

Motivation

I recently had an issue where the public key for a binary cache was pasted incorrectly into the extra substituters section of a flake.nix. All I received as error output when attempting to build was:

invalid character in Base64 str: '

After spending some time trying to bisect the issue I was still unable to determine what change had resulted in the error. That was when @zimbatm and @Mic92 suggested patching nix to better explain what was causing the problem.

@Mic92 put together this small patch and, after applying it, the underlying issue was immediately apparent since the error message contained the malformed public key entry.

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

• agreed on idea
• agreed on implementation strategy
• tests, as appropriate
  • functional tests - tests/**.sh
  • unit tests - src/*/tests
  • integration tests - tests/nixos/*
• documentation in the manual
• documentation in the internal API docs
• code and comments are self-explanatory
• commit message explains why the change was made
• new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

---

This is an automatic backport of pull request #8766 done by [Mergify](https://mergify.com).

[edolstra]

Closing this and the other backport branches since there is a small risk with this (see #11523) which isn't worth it on a stable branch.