Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure error messages don't leak private key #11523

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Ensure error messages don't leak private key #11523

merged 2 commits into from
Sep 23, 2024

Commits on Sep 20, 2024

  1. Revert "base64Decode: clearer error message when an invalid character… 

    … is detected"

We have a safer way of doing this.

This reverts commit dc3ccf0.
    @Ericson2314
    Ericson2314 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d0c351b View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Ensure error messages don't leak private key 

    Since NixOS#8766, invalid base64 is rendered in errors, but we don't actually
want to show this in the case of an invalid private keys.

Co-Authored-By: Eelco Dolstra <[email protected]>
    @Ericson2314 @edolstra
    Ericson2314 and edolstra committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2b6b03d View commit details
    Browse the repository at this point in the history