Make GitFileSystemObjectSink multi-threaded #12087
Draft
+177
−159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This speeds up importing tarballs into the Git cache.
Time for importing a nixpkgs tarballs on Nix master:
With this PR:
TODO: this currently buffers all file contents in memory before writing them to disk, so it's no longer constant memory. But this could be fixed pretty easily (e.g. if there are more than N bytes worth of unwritten files, then wait).
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.