Allow building a "store-only" nix #6225
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
split-libcmd
branch
from
4ad8c4e
to
b51f47f
Compare
Ericson2314
force-pushed
the
split-libcmd
branch
from
b51f47f
to
d9160df
Compare
|
Great... |
Ericson2314
force-pushed
the
split-libcmd
branch
3 times, most recently
from
59a1927
to
6571c90
Compare
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 3, 2023
`nix app` had something called `InstallableDerivedPath` which is actually the same thing. We go with the later's name because it has become more correct. I originally did this change (more hurriedly) as part of NixOS#6225 --- a mini store-only Nix and a full Nix need to share this code. In the first RFC meeting for NixOS/rfcs#134 we discussed how some splitting of the massive `installables.cc` could begin prior, as that is a good thing anyways. (@edolstra's words, not mine!) This would be one such PR.
7 tasks
Ericson2314
force-pushed
the
split-libcmd
branch
3 times, most recently
from
1196d90
to
35befd7
Compare
Ericson2314
force-pushed
the
split-libcmd
branch
2 times, most recently
from
d30af8d
to
35690e9
Compare
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
split-libcmd
branch
3 times, most recently
from
f31c6a1
to
b8ed149
Compare
Ericson2314
changed the title
github-actions
bot
added
fetching
Ericson2314
force-pushed
the
split-libcmd
branch
3 times, most recently
from
2b22320
to
5aa081e
Compare
Ericson2314
force-pushed
the
split-libcmd
branch
from
5aa081e
to
bf04560
Compare
It is good to do the inner mutation first on a local variable so the field is updated just once.
This is a nix without the expression language or flakes, with just a few commands. TODO: - Do --help without libexper. - Dedup the two `main.cc`s - Dedup the two `nix.md`s - Dedup the two `help.md`s Pop out parser Fix completions
Ericson2314
force-pushed
the
split-libcmd
branch
from
bf04560
to
d96e00b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nix without the expression language or flakes, with just a few
commands.
TODO:
Do
--helpwithout libexper.Dedup the two
main.ccsDedup the two
nix.mdsDedup the two
help.mdsFixes #6182
Depends on #7763