Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bump install-nix-action, don't fail fast #8534

Merged
merged 1 commit into from
Jun 17, 2023
Merged

ci: bump install-nix-action, don't fail fast #8534

merged 1 commit into from
Jun 17, 2023

Conversation

ncfavier
Copy link
Member

Motivation

#8470 (comment)

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

@ncfavier ncfavier requested a review from edolstra as a code owner June 17, 2023 13:05
@abathur
Copy link
Member

abathur commented Jun 17, 2023

  • no comment on fast fail
  • This cachix bump should supersede Pin the OSX version used on the CI #8529.
  • Some of the code sites are pinning nix 2.13.x, and the fix in the cachix action is leaning on a nix 2.15.x+ feature. Since the macOS job just ran clean I am hoping that means the feature isn't generally needed on macOS (I guess it might just be for hosted runners or something?)

@domenkozar domenkozar merged commit 3b0d8fd into NixOS:master Jun 17, 2023
@ncfavier ncfavier deleted the ci branch June 17, 2023 15:58
@emilazy
Copy link
Member

emilazy commented Jun 20, 2023

Should this be backported to 2.15-maintenance (and older)? Looks like all macOS CI is failing there right now.

@github-actions
Copy link

Backport failed for 2.13-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.13-maintenance
git worktree add -d .worktree/backport-8534-to-2.13-maintenance origin/2.13-maintenance
cd .worktree/backport-8534-to-2.13-maintenance
git checkout -b backport-8534-to-2.13-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

2 similar comments
@github-actions
Copy link

Backport failed for 2.13-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.13-maintenance
git worktree add -d .worktree/backport-8534-to-2.13-maintenance origin/2.13-maintenance
cd .worktree/backport-8534-to-2.13-maintenance
git checkout -b backport-8534-to-2.13-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Backport failed for 2.13-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.13-maintenance
git worktree add -d .worktree/backport-8534-to-2.13-maintenance origin/2.13-maintenance
cd .worktree/backport-8534-to-2.13-maintenance
git checkout -b backport-8534-to-2.13-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Backport failed for 2.14-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.14-maintenance
git worktree add -d .worktree/backport-8534-to-2.14-maintenance origin/2.14-maintenance
cd .worktree/backport-8534-to-2.14-maintenance
git checkout -b backport-8534-to-2.14-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

2 similar comments
@github-actions
Copy link

Backport failed for 2.14-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.14-maintenance
git worktree add -d .worktree/backport-8534-to-2.14-maintenance origin/2.14-maintenance
cd .worktree/backport-8534-to-2.14-maintenance
git checkout -b backport-8534-to-2.14-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Backport failed for 2.14-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.14-maintenance
git worktree add -d .worktree/backport-8534-to-2.14-maintenance origin/2.14-maintenance
cd .worktree/backport-8534-to-2.14-maintenance
git checkout -b backport-8534-to-2.14-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Backport failed for 2.13-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.13-maintenance
git worktree add -d .worktree/backport-8534-to-2.13-maintenance origin/2.13-maintenance
cd .worktree/backport-8534-to-2.13-maintenance
git checkout -b backport-8534-to-2.13-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Backport failed for 2.15-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.15-maintenance
git worktree add -d .worktree/backport-8534-to-2.15-maintenance origin/2.15-maintenance
cd .worktree/backport-8534-to-2.15-maintenance
git checkout -b backport-8534-to-2.15-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

2 similar comments
@github-actions
Copy link

Backport failed for 2.15-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.15-maintenance
git worktree add -d .worktree/backport-8534-to-2.15-maintenance origin/2.15-maintenance
cd .worktree/backport-8534-to-2.15-maintenance
git checkout -b backport-8534-to-2.15-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Backport failed for 2.15-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.15-maintenance
git worktree add -d .worktree/backport-8534-to-2.15-maintenance origin/2.15-maintenance
cd .worktree/backport-8534-to-2.15-maintenance
git checkout -b backport-8534-to-2.15-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Git push to origin failed for 2.16-maintenance with exitcode 1

@github-actions
Copy link

Backport failed for 2.14-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.14-maintenance
git worktree add -d .worktree/backport-8534-to-2.14-maintenance origin/2.14-maintenance
cd .worktree/backport-8534-to-2.14-maintenance
git checkout -b backport-8534-to-2.14-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Successfully created backport PR for 2.16-maintenance:

@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
@github-actions
Copy link

Git push to origin failed for 2.16-maintenance with exitcode 1

@github-actions
Copy link

Backport failed for 2.15-maintenance, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.15-maintenance
git worktree add -d .worktree/backport-8534-to-2.15-maintenance origin/2.15-maintenance
cd .worktree/backport-8534-to-2.15-maintenance
git checkout -b backport-8534-to-2.15-maintenance
ancref=$(git merge-base 741f7837f85d1675efbcf43877bbcdfb9a862745 b931d83550b200676c36ae8d1038a281ae4aa0ad)
git cherry-pick -x $ancref..b931d83550b200676c36ae8d1038a281ae4aa0ad

@github-actions
Copy link

Git push to origin failed for 2.16-maintenance with exitcode 1

@ncfavier
Copy link
Member Author

bro

@roberth
Copy link
Member

roberth commented Oct 23, 2023

Sorry for the spam.

@roberth roberth mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ncfavier @abathur @emilazy @roberth @domenkozar