Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move unit tests to separate directories, and document #8886

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Move unit tests to separate directories, and document #8886

merged 1 commit into from
Dec 1, 2023
+464 −352

Commits on Dec 1, 2023

  1. Move tests to separate directories, and document 

    Today, with the tests inside a `tests` intermingled with the
corresponding library's source code, we have a few problems:

- We have to be careful that wildcards don't end up with tests being
  built as part of Nix proper, or test headers being installed as part
  of Nix proper.

- Tests in libraries but not executables is not right:

  - It means each executable runs the previous unit tests again, because
    it needs the libraries.

  - It doesn't work right on Windows, which doesn't want you to load a
    DLL just for the side global variable . It could be made to work
    with the dlopen equivalent, but that's gross!

This reorg solves these problems.

There is a remaining problem which is that sibbling headers (like
`hash.hh` the test header vs `hash.hh` the main `libnixutil` header) end
up shadowing each other. This PR doesn't solve that. That is left as
future work for a future PR.

Co-authored-by: Valentin Gagarin <[email protected]>
    @Ericson2314 @fricklerhandwerk
    Ericson2314 and fricklerhandwerk committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    91b6833 View commit details
    Browse the repository at this point in the history