-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce libgit2 #9240
Merged
Merged
Introduce libgit2 #9240
Changes from 8 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e1b8442
Fetcher cache: Add support for caching facts not related to store paths
edolstra 1d0e3d8
Provide a InputScheme::fetch() built on top of InputScheme::getAccess…
edolstra ee36a44
GitInputScheme: Use libgit2
edolstra d88106d
Git fetcher: Improve submodule handling
edolstra 669b074
Cleanup
edolstra 0c5eac9
Git fetcher: Handle submodules for workdirs
edolstra 39ea46a
Merge remote-tracking branch 'origin/master' into libgit2
edolstra 98a120b
Merge remote-tracking branch 'origin/master' into libgit2
edolstra cf59ea8
configure: Check for libgit2
edolstra 21bb180
Use libgit2 with ssh-exec support
edolstra d74d2fd
Move statusCallbackTrampoline
edolstra 38b07d6
src/libfetchers/git.cc: Apply suggestion
edolstra 25cf8f1
src/libfetchers/union-input-accessor.cc: Apply suggestion
edolstra 4329bdf
Move comment
edolstra 21140c9
Fix doxygen comments
edolstra 7f576f5
Rename UnionInputAccessor to MountedInputAccessor
edolstra c257c82
Cleanup
edolstra 6ec6b8a
Improve git submodule error reporting
edolstra 2964a9f
Fix relative submodule handling
edolstra 2890999
Show Git fetch progress
edolstra 5dd4ae8
Remove unused cacheType field
edolstra 7ab91e7
Implement shallow fetching
edolstra 4ab27e5
Merge remote-tracking branch 'upstream/master' into libgit2
Ericson2314 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -194,6 +194,7 @@ | |
bzip2 xz brotli editline | ||
openssl sqlite | ||
libarchive | ||
libgit2 | ||
boost | ||
lowdown-nix | ||
libsodium | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cache behavior is hard to follow, but I suggest we fix that forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar for the many interactions with the
Inputs
object. I can't claim to fully understand how the attributes "evolve", let alone prove to myself that requirements about caching and reproducibility are upheld, but I figure I will have a better understanding after completing something based onNot a blocker for merging this.