Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reword description for the fetch-tree experimental feature #9353

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

fricklerhandwerk
Copy link
Contributor

this change leaves a factual description of the experimental feature and
its purpose.

Motivation

without knowing a lot of context, it's not clear who "we" are in that
text. I'm also strongly opposed to adding procedural notes into
a reference manual; it just won't age well.

Priorities

Add 👍 to pull requests you find important.

@Ericson2314
Copy link
Member

I am fine either way.

without knowing a lot of context, it's not clear who "we" are in that
text. I'm also strongly opposed to adding procedural notes into
a reference manual; it just won't age well.

this change leaves a factual description of the experimental feature and
its purpose.
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simplifies the text a lot without losing much meaning.
"Release candidate" is a bit vague, but nonetheless I think people get the gist of it. Explaining that will just make it wordy without adding much of substance.

@fricklerhandwerk fricklerhandwerk added the backport 2.19-maintenance Automatically creates a PR against the branch label Dec 4, 2023
@fricklerhandwerk fricklerhandwerk enabled auto-merge (rebase) December 4, 2023 15:16
@fricklerhandwerk fricklerhandwerk merged commit 5fe2acc into NixOS:master Dec 4, 2023
9 checks passed
Copy link

github-actions bot commented Dec 4, 2023

Successfully created backport PR for 2.19-maintenance:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.19-maintenance Automatically creates a PR against the branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants