Allow installing unit tests #9360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
knedlsepp
reviewed
Nov 16, 2023
Closes NixOS#9343 See that issue for motivation. Installing these is disabled by default, but we enable it (and the additional output we want isntall these too so as not to clutter the existing ones) to use in cross builds and dev shells.
Ericson2314
force-pushed
the
install-unit-tests
branch
from
4691031
to
6c8f4ef
Compare
thufschmitt
approved these changes
Nov 16, 2023
|
@thufschmitt I don't think the bash really needs it since there is nothing to compile? There is the plugin and the standalone executable test, but I think for those ensuring they compile is very much part of the test? At least I've been perfect happy with the "nix against nix" tests since your first introduced them in a0866c8 :) |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #9343
See that issue for motivation.
Context
Installing these is disabled by default, but we enable it (and the additional output we want isntall these too so as not to clutter the existing ones) to use in cross builds and dev shells.
Priorities
Add 👍 to pull requests you find important.