Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put canonicaliseTimestampAndPermissions in its own header/file #9394

Merged
merged 1 commit into from
Nov 22, 2023

Commits on Nov 21, 2023

  1. Put canonicaliseTimestampAndPermissions in its own header/file

    It is not inherently tied to `LocalStore`, it could probably even go in
    `libnixutil`. Functions not attached to `LocalStore` should not be
    declared in `local-store.hh`.
    
    I am moving it to facilitate experimenting for #9344. If
    canonicalisation should be done client-side in client-side builds, there
    wouldn't be a `LocalStore` at all so having to include that header to
    get this freestanding function is cumbersome and wrong.
    
    Perhaps canonicalisation should still be done server-side for security
    reasons --- I don't mean to make that judgement call now --- but even if
    so, this freestanding function still isn't connected to `LocalStore` so
    while less urgent it is still better to move out of this header.
    Ericson2314 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f880469 View commit details
    Browse the repository at this point in the history