application: Special case list arguments 2/2

NixOS · Oct 14, 2024 · ec04379 · ec04379
1 parent 1fde293
commit ec04379
Show file tree

Hide file tree

Showing 6 changed files with 68 additions and 78 deletions.
diff --git a/src/Nixfmt/Pretty.hs b/src/Nixfmt/Pretty.hs
@@ -469,10 +469,23 @@ prettyApp indentFunction pre hasPost f a =
 
       post = if hasPost then line' else mempty
   in pretty comment'
-      <> renderSimple
-        (absorbApp fWithoutComment)
-        (\fRendered -> group' RegularG $ fRendered <> hardspace <> absorbLast a)
-        (\fRendered -> group' RegularG $ fRendered <> line <> absorbLast a <> post)
+      <> case (fWithoutComment, a) of
+        -- When the two last arguments are lists, render these specially (same as above)
+        -- Also no need to wrap in renderSimple here, because we know that these kinds of arguments
+        -- are never "simple" by definition.
+        (Application fWithoutCommandAndWithoutArg l1@(Term List{}), l2@(Term List{})) ->
+          group' RegularG $
+            (pre <> group' Transparent (absorbApp fWithoutCommandAndWithoutArg))
+              <> line
+              <> nest (group (absorbInner l1))
+              <> line
+              <> nest (group (absorbInner l2))
+              <> post
+        _ ->
+          renderSimple
+            (absorbApp fWithoutComment)
+            (\fRendered -> group' RegularG $ fRendered <> hardspace <> absorbLast a)
+            (\fRendered -> group' RegularG $ fRendered <> line <> absorbLast a <> post)
       <> (if hasPost && not (null comment') then hardline else mempty)
 
 prettyWith :: Bool -> Expression -> Doc

diff --git a/test/diff/apply/out-pure.nix b/test/diff/apply/out-pure.nix
@@ -160,10 +160,7 @@
       ''"''
       "\${"
     ];
-    escapeMultiline = libStr.replaceStrings [ "\${" "''" ] [
-      "''\${"
-      "'''"
-    ];
+    escapeMultiline = libStr.replaceStrings [ "\${" "''" ] [ "''\${" "'''" ];
     test =
       foo
         [

diff --git a/test/diff/apply_with_lists/out-pure.nix b/test/diff/apply_with_lists/out-pure.nix
@@ -1,20 +1,15 @@
 # This file contains an assortment of test cases involving list-heavy function calls
 
 [
-  (f [ ] [
-    rhs
-    lhs
-  ])
+  (f [ ] [ rhs lhs ])
   (lib.mkMerge [
     false
     false
   ])
-  (replaceStrings [ "\${" "''" ]
+  (replaceStrings
+    [ "\${" "''" ]
     #force multiline
-    [
-      "''\${"
-      "'''"
-    ]
+    [ "''\${" "'''" ]
   )
   (replaceStrings [ ''"'' "\\" ] [ ''\"'' "\\\\" ] name)
   (replaceStrings
@@ -39,14 +34,20 @@
       ""
     ]
   )
-  (lists.removePrefix [
-    1
-    2
-  ] [ ])
-  (lists.removePrefix aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa [
-    1
-    2
-  ] [ ])
+  (lists.removePrefix
+    [
+      1
+      2
+    ]
+    [ ]
+  )
+  (lists.removePrefix aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
+    [
+      1
+      2
+    ]
+    [ ]
+  )
   (builtins.replaceStrings [ "@NIX_STORE_VERITY@" ] [ partitionTypes.usr-verity ]
     (builtins.readFile ./assert_uki_repart_match.py)
   )
@@ -59,15 +60,12 @@
   (lib.replaceStrings [ "https://registry" ".io/providers" ] [ "registry" ".io" ]
     homepage
   )
-  (lib.mkRenamedOptionModule [ "boot" "extraTTYs" ] [
-    "console"
-    "extraTTYs"
-  ])
+  (lib.mkRenamedOptionModule [ "boot" "extraTTYs" ] [ "console" "extraTTYs" ])
   # This line is engineered to exactly hit the line length limit
-  (lib.mkRenamedOptionModule [ "hardware" "package234" ] [
-    "hardware"
-    "graphics"
-  ])
+  (lib.mkRenamedOptionModule
+    [ "hardware" "package234" ]
+    [ "hardware" "graphics" ]
+  )
   (mkRenamedOptionModule
     [
       "services"
@@ -76,12 +74,7 @@
       "sddm"
       "enable"
     ]
-    [
-      "services"
-      "displayManager"
-      "sddm"
-      "enable"
-    ]
+    [ "services" "displayManager" "sddm" "enable" ]
   )
   (map (
     buildAllowCommand "allow" [

diff --git a/test/diff/apply_with_lists/out.nix b/test/diff/apply_with_lists/out.nix
@@ -1,20 +1,15 @@
 # This file contains an assortment of test cases involving list-heavy function calls
 
 [
-  (f [ ] [
-    rhs
-    lhs
-  ])
+  (f [ ] [ rhs lhs ])
   (lib.mkMerge [
     false
     false
   ])
-  (replaceStrings [ "\${" "''" ]
+  (replaceStrings
+    [ "\${" "''" ]
     #force multiline
-    [
-      "''\${"
-      "'''"
-    ]
+    [ "''\${" "'''" ]
   )
   (replaceStrings [ ''"'' "\\" ] [ ''\"'' "\\\\" ] name)
   (replaceStrings
@@ -39,14 +34,20 @@
       ""
     ]
   )
-  (lists.removePrefix [
-    1
-    2
-  ] [ ])
-  (lists.removePrefix aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa [
-    1
-    2
-  ] [ ])
+  (lists.removePrefix
+    [
+      1
+      2
+    ]
+    [ ]
+  )
+  (lists.removePrefix aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
+    [
+      1
+      2
+    ]
+    [ ]
+  )
   (builtins.replaceStrings [ "@NIX_STORE_VERITY@" ] [ partitionTypes.usr-verity ]
     (builtins.readFile ./assert_uki_repart_match.py)
   )
@@ -59,15 +60,12 @@
   (lib.replaceStrings [ "https://registry" ".io/providers" ] [ "registry" ".io" ]
     homepage
   )
-  (lib.mkRenamedOptionModule [ "boot" "extraTTYs" ] [
-    "console"
-    "extraTTYs"
-  ])
+  (lib.mkRenamedOptionModule [ "boot" "extraTTYs" ] [ "console" "extraTTYs" ])
   # This line is engineered to exactly hit the line length limit
-  (lib.mkRenamedOptionModule [ "hardware" "package234" ] [
-    "hardware"
-    "graphics"
-  ])
+  (lib.mkRenamedOptionModule
+    [ "hardware" "package234" ]
+    [ "hardware" "graphics" ]
+  )
   (mkRenamedOptionModule
     [
       "services"
@@ -76,12 +74,7 @@
       "sddm"
       "enable"
     ]
-    [
-      "services"
-      "displayManager"
-      "sddm"
-      "enable"
-    ]
+    [ "services" "displayManager" "sddm" "enable" ]
   )
   (map (
     buildAllowCommand "allow" [

diff --git a/test/diff/idioms_lib_3/out-pure.nix b/test/diff/idioms_lib_3/out-pure.nix
@@ -366,10 +366,7 @@ rec {
               ''"''
               "\${"
             ];
-            escapeMultiline = libStr.replaceStrings [ "\${" "''" ] [
-              "''\${"
-              "'''"
-            ];
+            escapeMultiline = libStr.replaceStrings [ "\${" "''" ] [ "''\${" "'''" ];
             singlelineResult =
               ''"'' + concatStringsSep "\\n" (map escapeSingleline lines) + ''"'';
             multilineResult =

diff --git a/test/diff/idioms_lib_3/out.nix b/test/diff/idioms_lib_3/out.nix
@@ -379,10 +379,7 @@ rec {
               ''"''
               "\${"
             ];
-            escapeMultiline = libStr.replaceStrings [ "\${" "''" ] [
-              "''\${"
-              "'''"
-            ];
+            escapeMultiline = libStr.replaceStrings [ "\${" "''" ] [ "''\${" "'''" ];
             singlelineResult =
               ''"'' + concatStringsSep "\\n" (map escapeSingleline lines) + ''"'';
             multilineResult =