Re-implement indented string parsing to be more preservative and match the Nix one #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
force-pushed
the
match-nix-str-parsing
branch
from
d6ec6f5 to
086f0bc
Compare
Closed
infinisil
force-pushed
the
match-nix-str-parsing
branch
from
086f0bc to
72361ab
Compare
|
Whether something like |
This should make sure that: - No sequences of characters get modified during parsing, indented strings are left exactly as is - We won't have any parsing bugs Also added a ton of docs to explain how it works and more tests
infinisil
force-pushed
the
match-nix-str-parsing
branch
from
72361ab to
ea74366
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-57/47823/1 |
dasJ
approved these changes
Jul 1, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements the indented string parser to fully preserve the input, while matching behavior to the Nix one. This fixes #197 as an alternative to #208.
In addition to fixing that issue though, this also fixes cases like
which was previously reformatted as
This work is sponsored by Antithesis ✨