Don't expand lists within functions

[piegamesde]

This is just a quick experiment to see where we can go with this.

[github-actions]

Nixpkgs diff

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/satisfaction-survey-from-the-new-rfc-166-formatting/49758/29

[piegamesde]

The format still looks a bit weird when the last two arguments are lists each. This can happen with partially applied string replacement, or with mkRemovedOptionModule for example. Not sure if it's worth special casing that though

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2024-08-20/50885/1

[infinisil]

Reviewed in the meeting today:

• First commit:
  • infinisil: Lists in the last argument should also be contracted
  • pie: Still a net improvement for now, can be more special-cased in the future
  • infinisil: Hopefully doesn't need an extra special case, can be done with a refactor perhaps
• Second commit (experiment to do the same for sets)
  • infinisil: Not a fan of this, doesn't seem like an improvement
  • pie: Okay let's drop this
• Third commit (experiment to absorb sets with single inherits)
  • infinisil: Fairly unopinionated on this, seems okay though
• pie: Will clean it up
• infinisil: Also mention that part of the code is duplicated in a comment

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2024-09-03/51584/1