-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvirtd: Add support for remote libvirt URIs #824
Changes from all commits
ecd5b44
13f10f8
775323b
0a6100f
07a918f
4914cc6
3ac4ca3
a7436f0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,11 +45,19 @@ in | |
###### interface | ||
|
||
options = { | ||
deployment.libvirtd.imageDir = mkOption { | ||
type = types.path; | ||
default = "/var/lib/libvirt/images"; | ||
deployment.libvirtd.storagePool = mkOption { | ||
type = types.str; | ||
default = "default"; | ||
description = '' | ||
The storage pool where the virtual disk is be created. | ||
''; | ||
}; | ||
|
||
deployment.libvirtd.URI = mkOption { | ||
type = types.str; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could this benefit from types.enum? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This may or may not reveal how little I know about libvirt :-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Probably not, this option can be an arbitrary URI string: https://libvirt.org/uri.html. It would be nice to have types.URL and types.URI though. :) |
||
default = "qemu:///system"; | ||
description = '' | ||
Directory to store VM image files. Note that it should be writable both by you and by libvirtd daemon. | ||
Connection URI. | ||
''; | ||
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is be"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to add an example ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the example here. This option is just the name of the libvirt storage pool. By default, there is a single storage pool named "default" which points to the /var/lib/libvirt/images directory. It is really hard for me to come up with a meaningful example here other than "default" here. :) But we already use "default" as the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I was not familiar with the terminology so this is the name of the storage pool ty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited the description, should be more clear this way.